Icons (various improvements part 2) #11
Conversation
arthomnix
commented
Jun 17, 2022
arthomnix
commented
- Show icons next to the name and description
- Disable the button for the currently selected tab to give a visual indication that it is selected
- Update Fabric Loader and API again
|
build failed because gradle couldn't find minotaur? |
| this.icon = new Identifier(VTDMod.MOD_ID, this.name.toLowerCase()); | ||
|
|
||
| if (MinecraftClient.getInstance().getTextureManager().getOrDefault(icon, null) == null) { | ||
| Thread iconDownloadThread = new Thread(() -> { |
There was a problem hiding this comment.
Opening a thread for each icon doesn't sound very efficient. It'd probably be better to have one or two threads downlading every icon
There was a problem hiding this comment.
Tried downloading on one thread and it's very slow to load the icons compared to each icon having its own thread, it's probably better to leave it like this
There was a problem hiding this comment.
Singlethreaded:
Multithreaded:
There was a problem hiding this comment.
It still doesn't convince me to open so many threads. Besides, not every icon is visible as soon as you open a tab, so downloading could be done once the user can see the entry. Instead of opening a lot of threads and never using them again, you could use a thread pool?
There was a problem hiding this comment.
Refactored to use a thread pool, let me know if you would prefer a different type of thread pool
