Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaturalSegmentMarkers implemented with Facade Pattern - more to come #122

Merged
merged 10 commits into from
Dec 9, 2023

Conversation

Ipuch
Copy link
Owner

@Ipuch Ipuch commented Dec 9, 2023

This change is Reviewable

Copy link

codeclimate bot commented Dec 9, 2023

Code Climate has analyzed commit 147a2e4 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c0849a4) 82.08% compared to head (147a2e4) 82.41%.
Report is 3 commits behind head on main.

Files Patch % Lines
bionc/bionc_casadi/natural_segment.py 97.67% 1 Missing ⚠️
bionc/bionc_casadi/natural_segment_markers.py 96.29% 1 Missing ⚠️
bionc/bionc_numpy/natural_segment.py 97.67% 1 Missing ⚠️
bionc/bionc_numpy/natural_segment_markers.py 96.15% 1 Missing ⚠️
bionc/protocols/natural_segment.py 90.90% 1 Missing ⚠️
bionc/protocols/natural_segment_markers.py 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   82.08%   82.41%   +0.32%     
==========================================
  Files          75       78       +3     
  Lines        5544     5624      +80     
==========================================
+ Hits         4551     4635      +84     
+ Misses        993      989       -4     
Flag Coverage Δ
unittests 82.41% <96.73%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ipuch Ipuch merged commit ca8e997 into main Dec 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant