Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facading natural segment vectors and segments in biomechanical model #124

Merged
merged 7 commits into from
Dec 16, 2023

Conversation

Ipuch
Copy link
Owner

@Ipuch Ipuch commented Dec 16, 2023

done.


This change is Reviewable

Copy link
Owner Author

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 7 files reviewed, all discussions resolved

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (147a2e4) 82.41% compared to head (8a2ca40) 81.65%.
Report is 1 commits behind head on main.

❗ Current head 8a2ca40 differs from pull request most recent head adf4229. Consider uploading reports for the commit adf4229 to get more accurate results

Files Patch % Lines
bionc/protocols/biomechanical_model_markers.py 0.00% 42 Missing ⚠️
bionc/bionc_numpy/biomechanical_model_segments.py 35.29% 22 Missing ⚠️
bionc/protocols/biomechanical_model_segments.py 92.00% 6 Missing ⚠️
bionc/protocols/biomechanical_model.py 83.33% 5 Missing ⚠️
bionc/bionc_casadi/natural_segment.py 75.00% 3 Missing ⚠️
bionc/protocols/natural_segment_vectors.py 85.00% 3 Missing ⚠️
bionc/bionc_numpy/natural_segment.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   82.41%   81.65%   -0.76%     
==========================================
  Files          78       85       +7     
  Lines        5624     5811     +187     
==========================================
+ Hits         4635     4745     +110     
- Misses        989     1066      +77     
Flag Coverage Δ
unittests 81.65% <72.20%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ipuch Ipuch changed the title facading natural segment vectors facading natural segment vectors and segments in biomechanical model Dec 16, 2023
Copy link

codeclimate bot commented Dec 16, 2023

Code Climate has analyzed commit adf4229 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@Ipuch Ipuch merged commit eee2d66 into main Dec 16, 2023
4 of 6 checks passed
@Ipuch
Copy link
Owner Author

Ipuch commented Dec 16, 2023

#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant