Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: joint angles and rotations matrices from Q are good #133

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Conversation

Ipuch
Copy link
Owner

@Ipuch Ipuch commented Jan 29, 2024

This change is Reviewable

Copy link

codeclimate bot commented Jan 29, 2024

Code Climate has analyzed commit ce64f52 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9093f3) 82.87% compared to head (ce64f52) 83.36%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   82.87%   83.36%   +0.49%     
==========================================
  Files          91       91              
  Lines        5862     5862              
==========================================
+ Hits         4858     4887      +29     
+ Misses       1004      975      -29     
Flag Coverage Δ
unittests 83.36% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner Author

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 10 files reviewed, all discussions resolved

@Ipuch Ipuch merged commit 191ad74 into main Jan 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant