Improve internal type safety, and import GHCi fix from persistent-sqlite #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are unedited, except for code formatting (e.g. "A @malloc()@ failed").
Otherwise, here's what you get, at least in 64-bit Linux:
$ ghci
> import Database.SQLite3
> conn <- open ":memory:"
<interactive>: /home/joey/.cabal/lib/direct-sqlite-2.0/ghc-7.4.2/HSdirect-sqlite-2.0.o: unknown symbol `stat64'
ghc: unable to load package `direct-sqlite-2.0'
This fix is imported from persistent-sqlite.
See http://www.haskell.org/pipermail/haskell-cafe/2012-July/102253.html
|
Great change. |
|
This all looks quite solid! I know the feeling of a patch going into the void, so I'm going to do my best to review it rapidly for you, but it is quite a lot to read through. I kinda wish it had been submitted as separate requests for each incremental patch (or even each logical group of them), just as something to keep in mind for the future. |
IreneKnapp
added a commit
that referenced
this pull request
Aug 16, 2012
Improve internal type safety, and import GHCi fix from persistent-sqlite. It is my great pleasure to merge this; I was able to read through it a lot faster than I expected when I saw the list of patches being so long. Thanks for breaking them up nicely, it made it a lot easier to understand the purpose of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes a lot internally, but should not cause any external breakage. It's mostly improvements to internal typing. However, the last commit is a hack imported from persistent-sqlite so direct-sqlite can be used with GHCi.
Here are all the user-facing changes I'm aware of:
Prelude.errorinstead of a non-exhaustive pattern match error.