Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the failing test for GetBackTraceLines #36

Merged
merged 1 commit into from Apr 29, 2013

Conversation

bpruitt-goddard
Copy link
Contributor

The test was failing because the number of BackTrace lines was different. It was passing when run from inside of the Visual Studio test runner, but failed when being run inside the build script. The stack traces differed by the Visual Studio version having the stacktrace point to the line in the ThrowException1 method. Once that method was removed, they both had 10 lines.

@Iristyle
Copy link
Owner

Hmmm.. I think the point of that test was to pull back a nested stack with inner exceptions... Does the back trace still contain that info?

@bpruitt-goddard
Copy link
Contributor Author

Yeah the stack trace still has 2 inner exceptions:

ex = "EX2"
ex.InnerException = "EX2"
ex.InnerException.InnerException = "EX1"

@Iristyle
Copy link
Owner

Ok cool -- that's good enough for me!

Iristyle added a commit that referenced this pull request Apr 29, 2013
Fixed failing test for GetBackTraceLines
@Iristyle Iristyle merged commit 1cefe3d into Iristyle:master Apr 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants