Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node 18 to release #107

Merged
merged 16 commits into from
Nov 12, 2022
Merged

Add node 18 to release #107

merged 16 commits into from
Nov 12, 2022

Conversation

coltfred
Copy link
Member

No description provided.

@coltfred coltfred requested a review from a team as a code owner November 11, 2022 19:44
@coltfred coltfred requested review from BobWall23 and removed request for a team November 11, 2022 19:44
@github-actions
Copy link

Commit SHA:0120f76ed8a13707634af877a7af8b9c3b7bdf5e
No changes to code coverage between the base branch and the head branch

@coltfred coltfred requested a review from a team as a code owner November 11, 2022 20:14
@github-actions
Copy link

Commit SHA:080790aa52b0d5c7a90fff50ba368001c3ed3bf3
No changes to code coverage between the base branch and the head branch

skeet70
skeet70 requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@skeet70 skeet70 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also want to run the update workflows script so your patch is applied here. You added 18 to the patch and to publish, but it's not in typescript-ci.

Add 18 to the README support matrix too.

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@skeet70 skeet70 mentioned this pull request Nov 11, 2022
Closed
@github-actions
Copy link

Commit SHA:484db7a03f9bbb21496924b3d500fc2416568269
No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

Commit SHA:4689f1d959f7748f201dd33d9f34148bddc9bd09
No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

Commit SHA:ce2e7595da0f39b47d4e6e0287d2bfbfbfbf723b
No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

Commit SHA:90a202ad83186375371e1ed57469c4e4f2ac3cf0
No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

Commit SHA:dda3cee92dc5bb06748a6e34b8872dd5ffebd29e
No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

Commit SHA:0d5be60d357bba43ae2f56ca11f188d0dab80bba
No changes to code coverage between the base branch and the head branch

skeet70
skeet70 requested changes Nov 11, 2022
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
@github-actions
Copy link

Commit SHA:a187d75c3b08da258d4aeb899d15a7049f698917
No changes to code coverage between the base branch and the head branch

@skeet70
Copy link
Member

skeet70 commented Nov 11, 2022

The link in the readme to Neon telling people what to install as dependencies has moved to https://neon-bindings.com/docs/quick-start/. The flake also needs the rust toolchain for yarn compile to be runnable.

@github-actions
Copy link

Commit SHA:19ea49905390ba5fea1f1b97c084caa015b91a08
No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

Commit SHA:6cc3b8749ec0fccf04adf285d36d947c78076971
No changes to code coverage between the base branch and the head branch

@skeet70
Copy link
Member

skeet70 commented Nov 11, 2022

Still needs the toolchain added to the flake, but the approval still stands once that happens.

@github-actions
Copy link

Commit SHA:aacb9c88fcdfcc2510ed2fb4ed43ab9fd8698486
No changes to code coverage between the base branch and the head branch

@coltfred coltfred merged commit 34ae623 into main Nov 12, 2022
@coltfred coltfred deleted the node-18 branch November 12, 2022 00:04
@github-actions
Copy link

Commit SHA:800155532377f842e0be08dcba996869647a3ba3
No changes to code coverage between the base branch and the head branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeet70 skeet70 skeet70 approved these changes

@BobWall23 BobWall23 Awaiting requested review from BobWall23 BobWall23 is a code owner automatically assigned from IronCoreLabs/ops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coltfred @skeet70 @leeroy-travis @cjyar