Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on arrayvec #152

Merged
merged 11 commits into from
Apr 12, 2021
Merged

Remove dependency on arrayvec #152

merged 11 commits into from
Apr 12, 2021

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Apr 9, 2021

Would need to bump MSRV to 1.48 because of this addition to Rust. We could possibly make do with an implementation available start in 1.43, but it doesn't seem as clean.

Open to opinions on if the bump to 1.48 is acceptable, or if we should make an attempt at the 1.43 version instead.

CI changes:

  • More resilient way of installing rustfmt, as it's not always available on nightly.
  • Switch to using rust_cache, which we've been moving towards already as we've been adding sccache. This is just an intermediate step towards that with less noise and some bugfixes built in

@clintfred
Copy link
Contributor

I think the PR description should mention the build changes. I think you are just using rust_cache?

Copy link
Contributor

@clintfred clintfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a minor patch version bump and an updated changelog.

@giarc3
Copy link
Member Author

giarc3 commented Apr 9, 2021

I think the PR description should mention the build changes. I think you are just using rust_cache?

I added a brief description of the CI changes. They were fairly minor.

@skeet70
Copy link
Member

skeet70 commented Apr 12, 2021

I think if we're bumping MSRV we should at least minor bump. Too easy for a patch version to break builds. We might want to make public policy about that.

@giarc3
Copy link
Member Author

giarc3 commented Apr 12, 2021

I think if we're bumping MSRV we should at least minor bump. Too easy for a patch version to break builds. We might want to make public policy about that.

You're 100% right. We do need a policy on that because we've been burned by it with our dependencies multiple times

CHANGELOG.md Outdated Show resolved Hide resolved
@giarc3 giarc3 merged commit 122095a into main Apr 12, 2021
@giarc3 giarc3 deleted the remove-arrayvec branch April 12, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants