Remove CustomTasks #453
Merged
Remove CustomTasks #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes CustomTasks, instead relying on the tasks from MSBuildCommunityTasks that we are already using.
|
What about generating a single CurrentVersion.Generated.cs instead of one per project? Maybe something to think about for the future. |
|
That's something I was thinking as well. I'll try and work that out. |
…thon2 into slide-remove_custom_tasks
|
The main issue I see with creating only one file is building in Visual Studio. I could easily generate the files in Build.proj as a pre-Target to other targets, but in Visual Studio, I don't know of a way to do that because it may be that only one project is built if only one project has changes. So, in that case, do I generate it every time a project is being built, which would then cause all projects needing to be built? |
slozier
approved these changes
Jul 12, 2018
dpmdpm
pushed a commit
to dpmdpm/ironpython2
that referenced
this pull request
Aug 2, 2018
* Small updates * [WIP] Remove CustomTasks This removes CustomTasks, instead relying on the tasks from MSBuildCommunityTasks that we are already using. * Pre-create the Properties directory * Make directories if they don't exist
slozier
added a commit
to slozier/ironpython3
that referenced
this pull request
Aug 17, 2018
slide
pushed a commit
to IronLanguages/ironpython3
that referenced
this pull request
Aug 17, 2018
* IronLanguages/ironpython2#367 * IronLanguages/ironpython2#368 * IronLanguages/ironpython2#452 and IronLanguages/ironpython2#406 * IronLanguages/ironpython2#413 * IronLanguages/ironpython2#372 * IronLanguages/ironpython2#453 * IronLanguages/ironpython2#435 * IronLanguages/ironpython2#458 * IronLanguages/ironpython2#383 * Update DLR * Fix copy/paste issues * IronLanguages/ironpython2#423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes CustomTasks, instead relying on the tasks from MSBuildCommunityTasks that we are already using.