Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working directory not fully cleaned by ./make clean #1436

Closed
BCSharp opened this issue May 3, 2022 · 0 comments · Fixed by #1503
Closed

Working directory not fully cleaned by ./make clean #1436

BCSharp opened this issue May 3, 2022 · 0 comments · Fixed by #1503

Comments

@BCSharp
Copy link
Member

BCSharp commented May 3, 2022

The impact of this issue has been reported in #1422 (comment) and #1433. Below is a copy of the discussion under #1433 about a possible solution.


Ok, managed to reproduce the failure. I think there might be a few issues:

[...]

  • Staging folder is not getting cleared. This might cause other junk to make its way into the package...
  • msi\obj is not getting cleaned? Somehow I managed to hit the same issue you had and zapping this folder "fixed" the issue.

Originally posted by @slozier in #1433 (comment)


I have noticed before that none of the 17 obj dirs are ever being cleaned, which on some occasion caused me problems. They usually contain both Release and Debug subdirs with often some files directly in obj. Thinking about a fix, it is not clear which target should clean them. Maybe a new target clean-all?

Originally posted by @BCSharp in #1433 (comment)


I guess part of the question is how much cleaning is expected of "clean". Like if you create a brand new .NET console program then run dotnet build and dotnet clean there's still a lot of stuff left over in the obj folder. Anyway, if we want to force clean everything maybe it could be called purge?

Originally posted by @slozier in #1433 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant