-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.4.0-beta #1422
Version 3.4.0-beta #1422
Conversation
I have still a few fringe items from the int/long unification, but nothing that has to land specifically before the release. If something does, fine, otherwise it can be done simply during regular development. I am going to bump up the priority of documenting the changes (which till now sat at the bottom of the int/long list). I don't expect any more changes visible from the user side. I can't think of any other stuff that may be needed. |
The milestone page shows #1209 as required for 3.4-beta. |
Yeah, apparently I thought it would be helpful with some IO issues people were having - but I don't remember what my idea was so we can probably punt it back to 3.6. |
Maybe this release is also a good moment to modify the version string reported with commandline option
The "3.4.0.0" seems superfluous and does not match the version reported by the interactive interpreter, which on the first line displays
|
I tweaked it to output:
CPython doesn't seem to have anything extra (like the |
One of the tools I am using (pylint?) runs the configured python with Having brief info which .NET is being used was convenient. In a way, .NET is an extension of StdLib, seen from the IronPython's perspective. Do you know what Jyton outputs? |
Python outputs letters as well (e.g.
Not sure about Jython, but PyPy has the following output:
|
Our issue template suggests running
|
Ahhh, Python has
|
This is perfect now! 👍 |
And now for something completely different... |
Answer to that is simple, because they're being excluded. 😉 Reason for exclusion is simple - they're essentially identical to the .NET Core 3.1 DLLs. I don't mind including .NET 6 if you think there's value (probably a good idea since .NET Core 3.1 support is ending in December). Though .NET 5 support is ending on May 8th(!) so I would not bother with it. Might be worth including .NET 6.0 in NuGet as well (though .NET Core 3.1 assemblies should still work so there's not much benefit...) |
Is it still true since the I would not bother with .NET 5 either, but having .NET 6 would be useful, at least could prevent questions like "where are .NET 6 assemblies?..." 😉 Even if the WPF DLLs are the same, I would still include them. Maybe the zip format has some options to deduplicate files. I got this question myself when I quickly wanted to grab this PR's binaries from GiHub CI so that I did not need to mess up my working dir with a checkout and build. First tried the MSI installer, but it only installs ipy for net46, right? Then looked into the zip and found .NET 6 "missing". Which makes me now wonder: what is the recommended way (on Windows) to install a stand-alone IronPython for .NET 6 with WPF support? |
No it's not true anymore, though most branches are perf related there are some differences (in particular the missing
Alright, I'll add it to the list.
There isn't one - best you can do is download the zip and run the .NET Core 3.1 version with the .NET 6 runtime (if you have both installed you can force .NET 6 with --fx-version or --roll-forward). A solution I've thought about is using .NET global tools to install the .NET 6 version which seems preferable to an MSI based approach. |
I did some reading on Is this something you wanted to support in this release (as "other stuff") or are thinking about some future point? |
Which part of venv is not working for you? I managed to set up an env from the MSI install.
Something for the future I think - I haven't looked into it at all and don't want to hold back this release longer than necessary. |
I should have clarified that I was talking about ipy for .NET 6 (that's why I don't know how to work around the issue without modifying I did some tests with setting an env from the MSI install and it seems to work OK, (both with and without option Thanks for including .NET6 DLLs! |
I don't mind patching def include_binary(self, f):
if f.endswith(('.pyd', '.dll')):
result = True
else:
if sys.implementation.name == "ironpython":
if f.endswith(".runtimeconfig.json"): return True
result = f.startswith('python') and f.endswith('.exe')
return result |
@BCSharp I'll probably try and do the release this evening - if you have anything else just let me know and I can hold off. |
I have no other points. From my side, the release is good to go. |
Hmm, when I run
The MSI installer is not created, nor is the zip file. I do have Python 3.7 installed system-wide, but the |
OK, I deleted the whole work area and cloned a fresh one, and everything works now. I wonder that that was about. |
Glad you figured it out. Release is out (though I need to redo the stdlib nuget package since I forgot to update the dependency... really need a checklist) |
Things left to do for the release:
@BCSharp Any potential PRs you'd like to squeeze in before a release? Can you think of anything else?