Type name #1315
Merged
Type name #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Not sure if you had other plans for this PR (it's marked as draft) but feel free to merge. We can always fix any stragglers later. |
|
This is it, for now. As you said, we can iron out the kinks as we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares the ground for #52.
A handful of calls to
PythonTypeOps.GetNameremain where they are used for debugging purposes.I also have left a few calls to
DynamicHelpers.GetPythonType(o).Nameinctypes. I don't know that code well enough to judge whether the change would be justified, and since it isctypesI thought it might be better to keep using the actual type name there.