Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish IConvertible members in BigIntegerOps #1366

Merged
merged 2 commits into from
Mar 20, 2022

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Mar 20, 2022

Follow-up on #1347 and #1329 (issue #52).

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

I guess this is for parity with the Int32 type? Looks like we used to hide all the IConvertible methods from the int type before?

@BCSharp
Copy link
Member Author

BCSharp commented Mar 20, 2022

I guess this is for parity with the Int32 type?

Yes.

Looks like we used to hide all the IConvertible methods from the int type before?

Yes, it changed with #1360. Right now, .NET interfaces are either always visible on non-Python-types, or never visible/resolved on Python types, there is nothing in between. I wish there were a mechanism to make them visible/resolvable only after import System, just like what [PythonHidden] does for methods.

I am thinking of adding such a mechanism to the type system but have no concrete ideas yet. Maybe I just special-case it for Int32.

@BCSharp BCSharp merged commit 0df9230 into IronLanguages:master Mar 20, 2022
@BCSharp BCSharp deleted the bigint_iconvertible branch March 20, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants