Rename ConvertToLong to ConvertToInt #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
reviewed
Apr 17, 2022
| public static object? ConvertIntToInt32(object? value) { | ||
| return value switch { | ||
| null => null, | ||
| int i => i, |
There was a problem hiding this comment.
Probably insignificant optimization, but maybe return value here? I guess the same applies to ConvertIntToBigInt.
There was a problem hiding this comment.
I thought about it and took the lead from ConvertToPythonPrimitive (a few lines above), which does more of this kind of stuff, presumably for readability (?).
OK to optimize it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1329 (issue #52).
Since
__long__is gone, to avoid confusion,XxxConvertToLongis renamed toXxxConvertToInt, while the oldXxxConvertToIntis gone. Plus some cleanup. A couple of functional changes are fixes:__int__returns aBigIntegerinstance, a conversion call site with return typeInt32succeeds or throwsOverflowExceptionif the value does not fit in 32 bits. Previously it was always throwingTypeErrorExceptionwith a rather cryptic message:__int__ returned non-int (int), regardless of the value.__complex__returns non-complex,TypeErrorExceptionwith a proper message is returned__complex__ returned non-complex (xxx)rather thanInvalidCastException.