Encoding folder update #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 4, 2019 19:43
FichteFoll
reviewed
Feb 6, 2019
| @@ -286,3 +286,5 @@ Just extract it somewhere. | |||
| --- | |||
|
|
|||
| [^1]: It should be noted that the author strongly disagrees with this sentiment. The two have a lot in common, and any capable Avisynth encoder could reach a similar leven in Vapoursynth within a few months, maybe even weeks. At least I'm honest, okay? | |||
|
|
|||
| [^2]: https://github.com/Irrational-Encoding-Wizardry/guide.encode.moe/issues/1 | |||
There was a problem hiding this comment.
Instead of adding a link to this, we should just fix the text.
There was a problem hiding this comment.
Agreed, but not really sure what the author of https://github.com/jpsdr/x264/releases meant. I didn't want to put something wrong there because I'm not sure exactly what happened on the release.
There was a problem hiding this comment.
Well, I guess something is better than nothing.
|
Also, good job with the separation of concern with these PRs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just semantic linefeed updates, for future cleaning and adding. Also added blocky artifact pitcure and additional explanation.