Added 12-clock (AM/PM) support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlikiKap
approved these changes
Sep 9, 2023
Iru21
requested changes
Oct 1, 2023
Comment on lines
+16
to
+23
| * Why is this? | ||
| * ``` | ||
| * Collections.sort(linesData, Comparator.comparing(String::length)) | ||
| * linesData = linesData.reversed() | ||
| * ``` | ||
| * If left that part: | ||
| * 1. When switch between 24 and 12 clock modes it moves lines because line length change. | ||
| * 2. When someone add localization, it's also going to move lines because words is diff length in different locale |
There was a problem hiding this comment.
Intended behaviour. It sorts lines so the longest one is at the top. Wastes less screen space
There was a problem hiding this comment.
Intended behaviour. It sorts lines so the longest one is at the top. Wastes less screen space
Maybe that can be also configurable? I'm ready to contribute it as another PR
There was a problem hiding this comment.
Sure, call it something like "Sort lines by length"
Iru21
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.