Test median #3
Test median #3
Conversation
| } else { | ||
| Arrays.sort(numbers); | ||
| int median; | ||
| if (numbers.length % 2 == 0) { |
There was a problem hiding this comment.
Variables can be extracted from 'if':
int size = numbers.length;
| */ | ||
|
|
||
| import java.util.Arrays; | ||
|
|
||
| public class Median { | ||
| public int median(int[] numbers){ |
There was a problem hiding this comment.
Recommended to use descriptive verbs that indicate what the method does
Here are some examples: findMedian, getMedian, calculateMedian
It can also return a double value if the length is even-numbered
There was a problem hiding this comment.
When I used assertEquals for double was error, that I use deprecated method, so first i tried with int. Now I found solution.
| */ | ||
|
|
||
| import java.util.Arrays; | ||
|
|
||
| public class Median { |
There was a problem hiding this comment.
Move this file to a named package
| if (numbers == null) { | ||
| return Integer.MAX_VALUE; | ||
| } | ||
| if (numbers.length == 0){ |
There was a problem hiding this comment.
There no spaces between ){
It's better to format the code: Ctrl+Alt+L
| int median; | ||
| if (numbers.length % 2 == 0) { | ||
| int middleIndex = numbers.length / 2; | ||
| median = (numbers[middleIndex] + numbers[middleIndex - 1]) /2; |
There was a problem hiding this comment.
if the length is even, the code returns an incorrect result
Probably because of the int cast
No description provided.