New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 signer address should be of type string #2

Open

williamchong wants to merge 1 commit into Irys-xyz:ethwallet from williamchong:ethwallet

williamchong commented Sep 19, 2023 •

edited

type signer calls (await this.signer.getAddress()).toLowerCase(), in which .toLowerCase() is a string only method


          fix: 🐛 signer address should be of type string

c45363d

Author

williamchong commented Sep 27, 2023 •

edited

ping @lukecd can you please confirm my fix here is needed/correct?
I am using the same patch in my production code also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment