Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Links on Steamcommunity get replaced with broken links #1790

Closed
Kissaki opened this issue Nov 11, 2023 · 6 comments
Closed

[BUG] Links on Steamcommunity get replaced with broken links #1790

Kissaki opened this issue Nov 11, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@Kissaki
Copy link

Kissaki commented Nov 11, 2023

Expected Behavior

When I open an external link on Steamcommunity discussions I either get the Steam leaving steam warning page or navigate to the target directly.

Actual Behavior

A default page or first page of the discussion is shown.

Steps to Reproduce the Problem

  1. Log in to steamcommunify.com
  2. Open a steam discussion with an external link
  3. Compare original/intended link target vs actual link target

During loading you can on-hover verify the link target is the correct URL before AugmentedSteam replaces it.
After loading finished, on-hover shows the link target has been replaced, seemingly to (part of) current page URL with /null suffix.

With Augmented Steam disabled the link remains the correct link.

Specifications

  • Augmented Steam Version: 2.6.0
  • Browser Version: Firefox 119

Potentially Relevant:

@Kissaki Kissaki added the bug Something isn't working label Nov 11, 2023
@Kissaki
Copy link
Author

Kissaki commented Nov 11, 2023

Apparently only occurs while logged in, not when logged out.

@Kissaki
Copy link
Author

Kissaki commented Nov 11, 2023

Example:

  • https://steamcommunity.com/groups/OnwardMarch/discussions/1/3960413951792928987/
  • Original link https://www.humblebundle.com/games/weplay-expo-discover-china-indies
  • steamcommunity link href https://steamcommunity.com/linkfilter/?u=https%3A%2F%2Fwww.humblebundle.com%2Fgames%2Fweplay-expo-discover-china-indies
  • augmented steam replaced broken link href https://steamcommunity.com/groups/OnwardMarch/discussions/1/3960413951792928987/null

@candela97
Copy link
Collaborator

Steam randomly changed the query string used to handle link filters 🙄. This isn't related to the issue you linked (that's for age gates).

You'll have to disable the Disable confirmation when accessing external sites option for now.

@nc7s
Copy link

nc7s commented Nov 26, 2023

Despite Steam changing parameters on their own, the extension can have a defensive check that if result is null stops replacing the links.

Edit: that is done in #1791.

@Fan4eGGG
Copy link

Fan4eGGG commented Feb 5, 2024

it's still not fixed? We still have to just disable the feature Disable confirmation when accessing external sites ?

tfedor added a commit that referenced this issue Feb 9, 2024
@tfedor
Copy link
Member

tfedor commented Feb 9, 2024

Fixed in next release

@tfedor tfedor closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants