Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Spark 3 Application History & Driver Logs directories #105

Merged
merged 3 commits into from Mar 15, 2023

Conversation

lfrancke
Copy link
Contributor

Strictly speaking this is optional if Spark 3 is not used

Copy link
Member

@tucked tucked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

LGTM, but I'm out of practice 😅
@brittup, could you take a look?

src/isilon_hadoop_tools/directories.py Outdated Show resolved Hide resolved
lfrancke and others added 2 commits March 10, 2023 10:52
Strictly speaking this is optional if Spark 3 is not used
Co-authored-by: David Tucker <48501491+tucked@users.noreply.github.com>
@teajason
Copy link
Collaborator

I am leaning the other direction on this PR. If it isn't default, then I think people installing Spark3 should add the directory themselves. This way we're not bloating the directories on default install. My suggestion is to not take this PR, .. @lfrancke Do you have a strong opinion on that?

@lfrancke
Copy link
Contributor Author

Well. Strictly speaking almost all users and directories are optional already. Spark3 is no different than HBase or Hive in that regard.

You can install CDP just fine without any of those but this tool will add the users and directories unconditionally. It'd be a bit weird to single out this one dependency.

But to answer your question: No. No strong feelings :)

@teajason teajason merged commit 65347f5 into Isilon:main Mar 15, 2023
5 checks passed
@tucked tucked added this to the 5.0.1 milestone Jun 21, 2023
@lfrancke lfrancke deleted the spark3 branch June 22, 2023 15:05
@tucked tucked added the patch This change requires a Patch version bump. label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This change requires a Patch version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants