Access Control for Starter Site #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable Delegate script for Cantaloupe
rosiel
reviewed
Jul 13, 2023
Makefile
Outdated
| @@ -183,7 +184,7 @@ starter_dev: QUOTED_CURDIR = "$(CURDIR)" | |||
| starter_dev: generate-secrets | |||
| $(MAKE) starter-init ENVIRONMENT=starter_dev | |||
| if [ -z "$$(ls -A $(QUOTED_CURDIR)/codebase)" ]; then \ | |||
| docker container run --rm -v $(CURDIR)/codebase:/home/root $(REPOSITORY)/nginx:$(TAG) with-contenv bash -lc 'git clone -b main https://github.com/Islandora-Devops/islandora-starter-site /home/root;'; \ | |||
| docker container run --rm -v $(CURDIR)/codebase:/home/root $(REPOSITORY)/nginx:$(TAG) with-contenv bash -lc 'git clone -b islandora_group https://github.com/kylehuynh205/islandora-starter-site.git /home/root;'; \ | |||
There was a problem hiding this comment.
I get that this is how to get it running, but we are not helped by committing feature branches into our toolchain!
rosiel
reviewed
Jul 13, 2023
Makefile
Outdated
| @@ -160,7 +160,8 @@ local: generate-secrets | |||
| curl -k -u admin:'$(shell cat secrets/live/DRUPAL_DEFAULT_ACCOUNT_PASSWORD)' -H "Content-Type: application/json" -d "@build/demo-data/homepage.json" https://${DOMAIN}/node?_format=json | |||
| curl -k -u admin:'$(shell cat secrets/live/DRUPAL_DEFAULT_ACCOUNT_PASSWORD)' -H "Content-Type: application/json" -d "@build/demo-data/browse-collections.json" https://${DOMAIN}/node?_format=json | |||
| $(MAKE) login | |||
|
|
|||
| # make private file directory | |||
| docker-compose exec -T drupal mkdir -p $(CURDIR)/codebase/web/sites/default/private_files | |||
There was a problem hiding this comment.
Best practice is to create a directory outside of the web root. Otherwise (unless you take careful explicit steps to protect it) all the files will be directly accessible over the internet.
There was a problem hiding this comment.
I moved it out to outside web directory kylehuynh205/islandora-starter-site@7672e77
There was a problem hiding this comment.
Cool. Where is the command that creates the private_files directory?
rosiel
reviewed
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add steps to create private file directory
Enable Delegate script for Cantaloupe