MIG changes May 2021 #69
Conversation
|
Is the change here to rebrand |
|
I am not seeing a record of changing this field name as part of the MIG work documented here Looking around a bit more to see if anything jogs my memory. |
|
Ok, I have developed a theory @dannylamb @rosiel had mentioned we did work based on a Sandbox that was running the last release (from 2020-01-05), so what we based our sprint on didn't include any contributions that had been made in the meantime. Like Natkeeran's creation of field.field.taxonomy_term.language.field_authority_link.yml, merged 2020-01-13. So we duplicated work that had already been done since that release and introduced this minor inconsistency in how fields were set up because we were not seeing the precedent that has been merged into the code base since 2020-01-05. It looks to me like all the machine names of the fields with I am betting I typed in the field label "Authority Sources", when creating the "New" genre taxonomy in defaults, since that is what the label for these fields is in the other taxonomies, and it auto-generated the |
|
I'm working on a PR to Rosie's fork that can be used here if @rosiel deems it fit to merge |
MIG did not have the latest `controlled-access-terms` applied to the sandbox on which we were doing our work, so some things got a bit duplicated inexactly.
reconcile inconsistencies introduced by MIG Sprint based on old code
GitHub Issue: (link)
Companion to: Islandora/islandora_defaults#52
What does this Pull Request do?
Updates names/descriptions/fields on taxonomy vocabularies per MIG recommendations.
What's new?
Rename and redescribe fields.
How should this be tested?
Does it build (requirements aren't messed up)?
Additional Notes:
Interested parties
Hey @Islandora/8-x-committers
New interface upgrades for the release!