Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EDTF formatting issues #2016

Closed
seth-shaw-unlv opened this issue Dec 21, 2021 · 1 comment
Closed

New EDTF formatting issues #2016

seth-shaw-unlv opened this issue Dec 21, 2021 · 1 comment
Labels
Subject: Dates related to managing dates in Islandora. Consider also using the search and metadata tags.

Comments

@seth-shaw-unlv
Copy link
Contributor

While testing out @Natkeeran 's newspaper fixes I came across some issues with the recent "do not show" options for controlled_access_terms.

E.g. I created a record with today's date using the date created field from islandora_defaults:
Screen Shot 2021-12-21 at 11 49 51 AM
If you then go to the date created display settings you will notice that the year format inexplicitly says "Do not show year" even though it does:
Screen Shot 2021-12-21 at 11 50 54 AM
Also, the two-digit year option copied the option text from month:
Screen Shot 2021-12-21 at 11 52 05 AM
Regardless, the year setting always shows the "do not show year" option as selected, even when it wasn't before.

I have a PR incoming for that issue.

Further, the middle-endian order will display the year regardless of the year setting. E.g. the settings in the screenshot below will result in the year displaying even when configured not to:
Screen Shot 2021-12-21 at 11 53 57 AM
Screen Shot 2021-12-21 at 11 54 30 AM

The simple workaround for the second issue is to simply use either the big or small-endian options if you don't want to show the year. No code fix for that bit yet.

@kstapelfeldt kstapelfeldt added the Subject: Dates related to managing dates in Islandora. Consider also using the search and metadata tags. label Jan 5, 2022
@Natkeeran
Copy link
Contributor

This PR works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Dates related to managing dates in Islandora. Consider also using the search and metadata tags.
Projects
None yet
Development

No branches or pull requests

3 participants