Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow year and month to be hidden when displaying EDTF dates #75

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Allow year and month to be hidden when displaying EDTF dates #75

merged 3 commits into from
Dec 9, 2021

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: N/A

What does this Pull Request do?

Allow year and month to be hidden when displaying EDTF dates. Taken from Born-Digital's updates to carapace. They used it for the newspaper view; this PR pulls in these nice additions for those not using carapace.

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Added 'no value' options for month.
  • Added year formatting options
  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? No.

How should this be tested?

  • Apply the PR
  • Use the EDTF date formatter settings to hide a month and/or year
  • Ensure nothing blows up on us.

Interested parties

@Islandora/8-x-committers and @noahwsmith

Allow year and month to be hidden. Taken from Born-Digital's updates to carapace.
@noahwsmith
Copy link

cc @dannylamb for comment and code review. Seth and I talked about this last week and I suggested he extract this from our install-profile if it seemed more broadly usable 👍

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't merge this since the code came from my organization, but I'm 👍 to this.

@rosiel rosiel merged commit fb69281 into Islandora:2.x Dec 9, 2021
@seth-shaw-unlv seth-shaw-unlv deleted the seth-shaw-unlv-patch-1 branch December 9, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants