This is just to talk about Dependency Injection #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just thought I should point out that there is exactly 1,337 additions. |
|
@daniel-dgi OH MY GOD. |
| @@ -22,23 +23,12 @@ | |||
| 'twig.path' => __DIR__.'/../templates', | |||
| )); | |||
|
|
|||
| $islandoraResourceServiceProvider = new \Islandora\ResourceService\Provider\ResourceServiceProvider; | |||
There was a problem hiding this comment.
Sorry, some how lost here. How does the collection.controller makes use of the resource routes without having them registered or mounted? Who is mounting them? Thanks!
There was a problem hiding this comment.
It's totally non-functional. Was just trying to make a point about injecting things in and making sure to use PHP's type system for guarantees. I've yet to pull out the rest of the Resource Service stuff.
There was a problem hiding this comment.
Oh, right! Well sorry for being so silly. Thanks! I will go inject myself 👍
There was a problem hiding this comment.
LOL, no worries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.