Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 002 issue 150 #206

Closed
wants to merge 4 commits into from
Closed

Sprint 002 issue 150 #206

wants to merge 4 commits into from

Conversation

br2490
Copy link

@br2490 br2490 commented Apr 25, 2016

SANITY CHECK, DO NOT MERGE.
First attempt to contribute to microservices.

Addressing #150 , delete all oreProxy when delete is called on resource service.

Looking for feedback, please! I will continue to work on this by wrapping in a TX, adding a return (which I'm not sure what I should be returning), and removing debug lines. Am I in the right direction? Is it okay that I'm using a pseudo queue to gather all of objects before actually deleting them? This is not how it is done in other services so if I should align myself with how other services behave I will. Anything?! Thanks :)

@br2490
Copy link
Author

br2490 commented Apr 25, 2016

Also I'll make sure to pull from a clean branch...

@ruebot
Copy link
Member

ruebot commented Apr 25, 2016

I think you're fine on this one. In the future, just make sure you do a pull before you start your work, and it's a good idea to do a pull before you do the pull request just to make sure you're not going to have any merge conflicts.

@br2490
Copy link
Author

br2490 commented Apr 25, 2016

Agreed and thanks.

Sent from my phone. Forgive brevity and autocorrect.
On Apr 25, 2016 3:04 PM, "Nick Ruest" notifications@github.com wrote:

I think you're fine on this one. In the future, just make sure you do a
pull before you start your work, and it's a good idea to do a pull before
you do the pull request just to make sure you're not going to have any
merge conflicts.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#206 (comment)

@br2490
Copy link
Author

br2490 commented Apr 26, 2016

@whikloj when you have time could you look at a7b1fc6

@ruebot ruebot mentioned this pull request Apr 26, 2016
@ruebot
Copy link
Member

ruebot commented Apr 26, 2016

Superseded by #210

@ruebot ruebot closed this Apr 26, 2016
@br2490 br2490 deleted the sprint-002-issue-150 branch May 12, 2016 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants