Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fedora docs #2240

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Update Fedora docs #2240

merged 5 commits into from
Jul 11, 2023

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Jun 12, 2023

Purpose / why

Update the Fedora parts of this based on our experience setting up Fedora/Syn

What changes were made?

  • updated the documentation page
  • added syntax highlighting features
  • added copy buttons to some code blocks

Verification

Compare to the final installation inside Isle or playbook, or give it a try.

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Add syntax highlighting and copy buttons
@whikloj
Copy link
Member Author

whikloj commented Jun 12, 2023

@adam-vessey
Copy link
Contributor

@whikloj :

Just, rationale for the "preview" thing having failed: https://github.com/rossjrw/pr-preview-action

This Action does not currently support deploying previews for PRs from forks, but will do so in rossjrw/pr-preview-action#6.

@whikloj
Copy link
Member Author

whikloj commented Jun 12, 2023

Ohhhh so I should have opened this from the documentation repo. I'll try to remember that in the future.

@ysuarez
Copy link
Contributor

ysuarez commented Jun 12, 2023

I was just trying a pull request from my fork to see if that was the reason, but now I see that it was confirmed as the reason. At least it gave me an excuse to create a PR I had been meaning to create.

@rosiel rosiel self-assigned this Jun 14, 2023
@rosiel
Copy link
Member

rosiel commented Jul 11, 2023

Looks great. I got to the bottom of the file and things worked. The only error I got was that comments in the fcrepo.properties file aren't valid, so I made a PR with a small warning to take them out. whikloj#1

I will admit I haven't finished the manual install instructions, but this page seems good to go (with the small addition above).

@whikloj
Copy link
Member Author

whikloj commented Jul 11, 2023

Hey @rosiel, sorry about that. I moved the comments to their own lines. I can still merge your addition, but this allows the copy block to work.

@rosiel rosiel merged commit e0a06fc into Islandora:main Jul 11, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants