Initial pull request #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-standard but widely-used .m4a extension. Also removed some commented-out test cases.
…fault collection object.
|
Accepted. Closes JIRA issue ISLANDORA-127 |
jonathangreen
pushed a commit
that referenced
this pull request
Aug 28, 2012
minor changes to fits integration
jordandukart
added a commit
that referenced
this pull request
Apr 18, 2013
Code Review - Refactor and fixes.
MorganDawe
added a commit
that referenced
this pull request
May 17, 2014
Add a test for our temp file utility function.
ruebot
added a commit
that referenced
this pull request
Feb 5, 2015
Simplification as single object entry is deprecated.
jordandukart
pushed a commit
that referenced
this pull request
Mar 10, 2015
Slight change to avoid potential caching issues.
daniel-dgi
referenced
this pull request
in daniel-dgi/islandora
Nov 2, 2015
Update islandora.cfg path and filename.
ruebot
pushed a commit
to yorkulibraries/islandora
that referenced
this pull request
Apr 11, 2017
* JSON-LD Context generator Base pull, service, interface and class. Needs testing. DCS should be solved already * Missing an @ * Wrong Cache backend service injected * make sure the bundle has mapping * Testing routes to make debugging easier * phpstorm, leave my indentation alone! * phpcs for test controller * Changes, lots of them * Exceptions thrown all around (and documented * “Try/Catch” where relevant * Logger channel for ISLANDORA, useful for all CLAW * Exceptions are being cached * Naive field types of json-ld term definitions for context. Kinda poor mans rdf map for fields * Docs, docs. * Route Controller now responds with application/ld+json, means don’t wait for HTML! * Concerns addressed TODO: need new tests. * Web tests! Don’t run via UI (buggy) https://www.drupal.org/node/2745123 Do this ```Shell sudo -u www-data php core/scripts/run-tests.sh --verbose --class "Drupal\islandora\Tests\Web\JsonldContextGeneratorWebTest" ``` * Coding standards * Coding standards and Cache Now caching happens on the response and on the method. Best of both worlds. ```Shell curl -i http://localhost:8000/fedora_resource_context/rdf_source HTTP/1.1 200 OK Date: Tue, 21 Mar 2017 19:19:03 GMT Server: Apache/2.4.18 (Ubuntu) Cache-Control: must-revalidate, no-cache, private X-Powered-By: Islandora CLAW API X-Drupal-Dynamic-Cache: MISS X-UA-Compatible: IE=edge Content-language: en X-Content-Type-Options: nosniff X-Frame-Options: SAMEORIGIN Expires: Sun, 19 Nov 1978 05:00:00 GMT X-Generator: Drupal 8 (https://www.drupal.org) X-Debug-Token: 7d33c2 X-Debug-Token-Link: /admin/reports/profiler/view/7d33c2 X-Drupal-Cache: HIT Content-Length: 229 Content-Type: application/ld+json {"@context":{"schema":"http://schema.org/","schema:dateModified":{"@type ":"xsd:dateTime"},"schema:dateCreated":{"@type":"xsd:dateTime"},"fedora" :"http://fedora.info/definitions/v4/repository#","fedora:hasParent":{"@t ype":"@id"}}} ```` and after cache clear (or changing user permissions or even an entity type def associated to the requested rdfmapping) ```Shell HTTP/1.1 200 OK Date: Tue, 21 Mar 2017 19:20:49 GMT Server: Apache/2.4.18 (Ubuntu) Cache-Control: must-revalidate, no-cache, private X-Powered-By: Islandora CLAW API X-Drupal-Dynamic-Cache: MISS X-UA-Compatible: IE=edge Content-language: en X-Content-Type-Options: nosniff X-Frame-Options: SAMEORIGIN Expires: Sun, 19 Nov 1978 05:00:00 GMT X-Generator: Drupal 8 (https://www.drupal.org) X-Debug-Token: acc399 X-Debug-Token-Link: /admin/reports/profiler/view/acc399 X-Drupal-Cache: MISS Content-Length: 229 Content-Type: application/ld+json ```` * Short notion array.. should be named “bracket structure…” * We should run tests on our own server... * lets try with 127.0.0.1 * testing travis changes (Islandora#1) * fixes not working Drupal/drush integration on Travis-CI * Kernel tests * 400 is 1 less than 401 * restore notifications * Fixes type in TODO * Jared rocks * Debug statement not needed Was not outputting anyway * Namespace change Addressing @dhlamb namespace change
mjordan
pushed a commit
that referenced
this pull request
Mar 21, 2018
…e replaced with any file type (#1) * Return empty if no restriction set, enforce this on the form
dannylamb
pushed a commit
that referenced
this pull request
Oct 15, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Islandora Organization (of which I am a member):
In an effort to familiarize myself with the [ fork > ( clone > change > commit > fetch/merge upstream > push ) > send pull-request ] kind of workflow, I submit this pull-request of a minuscule change to the mime class which I've made on my own fork.