Validate JWT expiry #776
Merged
Validate JWT expiry #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you meant @Islandora/8-x-committers . |
|
Hmm I guess I got the wrong template, cause I didn't type that in 🤷 |
dannylamb
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: Islandora/documentation#1498
What does this Pull Request do?
Tightens allowed time intervals for JWT expiry.
What's new?
You must have a positive integer, you must use one of the expected time intervals.
It is possible to create some weird strings, but I haven't really tested all the things that
strtotime()might allow.How should this be tested?
Pull in this code and try adding some weird expiry intervals.
Interested parties
@Islandora/7-x-1-x-committers