Replace deprecated annotation 'context' with 'context_definitions' #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seth-shaw-asu
approved these changes
Feb 1, 2023
rosiel
pushed a commit
to rosiel/islandora
that referenced
this pull request
Feb 22, 2023
…itions' (Islandora#925) There was a cleanup done for this deprecation in Islandora#764 before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have just been missed in reviewing Islandora#808.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Addresses a deprecation that was missed.
What's new?
Just an extension of the work done in #764.
The deprecated annotation resulted in the 'Node reference by node' Condition failing to work in an environment using Drupal 9.4.
How should this be tested?
The 'Node referenced by node' Condition should now work as expected.
Honestly with how minimal this is, a full test case seems a little over-the-top. However, #808 can be referenced for how to test the functionality of this Condition Plugin.
Additional Notes:
There was a cleanup done for this deprecation in #764 before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have just been missed in reviewing #808.
Interested parties
@Islandora/committers