Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the 'Fedora URI' label as a label. #970

Closed
wants to merge 2 commits into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Aug 7, 2023

GitHub Issue: LEAF-VRE/islandora-UX-useathon#13

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Bolds the Fedora URI label.

What's new?

  • Changes the HTML tag surrounding the "Fedora URI" pseudo-field label to match field labels.
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code?
    • This could mess up your custom CSS if you are fixing this issue a different way.

How should this be tested?

Load up a repository item and see that the Fedora URI field should be bolded.

Screenshot 2023-08-07 at 4 06 17 PM

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? n/a
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@steinburgb
@ilovan
@Islandora/committers

@rosiel
Copy link
Member Author

rosiel commented Aug 10, 2023

Discussion in the Tech call resolved that this should have been done by integrating this pseudo-field more closely with actual fields, not by naively using fake wrapper html. Also there is probably a better render element for this to use. Also this probably should be re-factored into a separate (Fedora integration) module.

Closing as undesirable.

@rosiel rosiel closed this Aug 10, 2023
@rosiel rosiel deleted the fedora-uri branch August 10, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant