Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISLANDORA-1042 -- DESTROY ALL DEPRECATED CODE! #61

Merged
merged 1 commit into from
Sep 25, 2014
Merged

ISLANDORA-1042 -- DESTROY ALL DEPRECATED CODE! #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions includes/bookmark.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,46 +124,6 @@ abstract class Bookmark implements BookmarkInterface {
$this->isDeletable = TRUE;
}

/**
* Somewhat more graceful deprecation of old properties.
*/
public function __get($property) {
if ($property == 'userList') {
module_load_include('inc', 'islandora', 'includes/utilities');
$message = islandora_deprecated('7.x-1.3', 'Use the methods {get,add,remove}Users(), instead of accessing as a property.');
trigger_error(filter_xss($message), E_USER_DEPRECATED);
return $this->getUsers();
}
elseif ($property == 'pidList') {
module_load_include('inc', 'islandora', 'includes/utilities');
$message = islandora_deprecated('7.x-1.3', 'Use the methods {get,add,remove}Pids(), instead of accessing as a property.');
trigger_error(filter_xss($message), E_USER_DEPRECATED);
return $this->getPids();
}
}

/**
* Somewhat more graceful deprecation of old properties.
*/
public function __set($property, $value) {
if ($property == 'userList') {
module_load_include('inc', 'islandora', 'includes/utilities');
$message = islandora_deprecated('7.x-1.3', 'Use the methods {get,add,remove}Users(), instead of accessing as a property.');
trigger_error(filter_xss($message), E_USER_DEPRECATED);
$this->removeUsers($this->getUsers());
$this->addUsers($value);
return $value;
}
elseif ($property == 'pidList') {
module_load_include('inc', 'islandora', 'includes/utilities');
$message = islandora_deprecated('7.x-1.3', 'Use the methods {get,add,remove}Pids(), instead of accessing as a property.');
trigger_error(filter_xss($message), E_USER_DEPRECATED);
$this->removeAllPids();
$this->addPids($value);
return $value;
}
}

/**
* Accessor for the list ID.
*
Expand Down