Add ability to retroactively enable checksums

[mjordan]

@ruebot, I'll let you update the screencap linked in the README. Also, coder is showing the following code style error"

Line 60: No key specified for array entry; first entry specifies key [sniffer_squiz_arrays_arraydeclaration_nokeyspecified]
    ),

Code looks good to me - know how to fix that?

[ruebot]

Restarting the Travis build

[ruebot]

Looks like you got burned by a Drupal Coding Standard error:

sites/all/modules/islandora_checksum/includes/admin.form.inc:
+60: [minor] No key specified for array entry; first entry specifies key

[mjordan]

You know how to fix it? I can't figure out what the actual problem is.

[ruebot]

I think it wants these blocks in admin.inc to looks like this:

$form['islandora_checksum_checksum_retro_enable'] = array(
   '#type' => 'fieldset',
   '#title' => t('Retroactively enable checksums'),
);

Like how we do it here.

Basically, I think you just need to change line 60 from ), to );, and I think the same goes for 66, 72, 77, and 80.

[mjordan]

OK, thanks, lemme have a go in a few minutes.

[mjordan]

OK, fixed. I'll commit, push, and issue a new PR.

[mjordan]

OK, github magic - didn't need to open new PR.

[ruebot]

Welcome to magic of Github!

[mjordan]

You may want to update the screencap in the README.

[ruebot]

Ah, yeah good call! I'll do that when I get home, or at least add it to my
to do list. You'll get to merge it :-)
On 13 Mar 2014 16:37, "Mark Jordan" notifications@github.com wrote:

You may want to update the screencap in the README.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-37583628
.

[dmoses]

Lads ... I dl'd and tested the module. It is working, but I did notice some odd behavior. I selected the checksum type, selected a collection then selected Enable. It runs though a process and looks like the checksum got applied. I checked the object with fedora/admin ... no checksum got applied. The user needs to save the configuration, then select Enable for the checksums to get generated. This is obvious now, but I missed it.

[mjordan]

Correct Don, if you are running the retro function before saving the config, it will actually rip through your objects and set the checksum type to 'DISABLED' (see https://github.com/Islandora/islandora_checksum/blob/7.x/islandora_checksum.module#L132), which is what you saw happening. That is a documentation oversite that will be fixed (I'll take care of it Nick).

[mjordan]

OK, corrected.