Update islandora_drupal_filter to replace Apache Commons logging with SLF4J logging. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignores Eclipse artifacts and the maven target
Apache Commons logging has been explicitly excluded in the FCrepo POM files as of 3.6.x, necesitating these code changes to use the SLF4J logging library.
|
We should create separate branches for each version of Fedora rather than having branches per Drupal version. |
|
That probably makes sense. The risk of going that way is that the Drupal database schema might change between releases, but that didn't happen with the 6.x to 7.x upgrade. Let me know if you want me to apply the pull request to a different branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache Commons logging has been explicitly excluded in the FCrepo POM files as of 3.6.x, necesitating these code changes to use the SLF4J logging library.