Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address ISLANDORA-977. #122

Merged
merged 3 commits into from
Sep 26, 2014
Merged

Address ISLANDORA-977. #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55e0287
Address ISLANDORA-977.
ruebot Sep 5, 2014
809e65b
Merge branch '7.x' of github.com:islandora/islandora_scholar into 7.x…
ruebot Sep 15, 2014
b30e8b3
Move those variables to the right module.
ruebot Sep 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion islandora_scholar.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,20 @@ function islandora_scholar_install() {
function islandora_scholar_uninstall() {
module_load_include('inc', 'islandora', 'includes/solution_packs');
islandora_install_solution_pack('islandora_scholar', 'uninstall');
// @todo add rest of variables to delete at uninstall.
$variables = array(
'islandora_scholar_use_standard_metadata_display',
'islandora_scholar_users_choose_display_csl',
'islandora_scholar_romeo_enable',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be split out into the individual modules.

'islandora_scholar_thumbnail_width',
'islandora_scholar_thumbnail_height',
'islandora_scholar_path_to_pdftotext',
'islandora_scholar_preview_width',
'islandora_scholar_preview_height',
'islandora_scholar_issn_cache_time',
'islandora_scholar_romeo_key',
'islandora_scholar_romeo_url',
'islandora_scholar_romeo_cache_time',
'islandora_scholar_create_fulltext',
);
array_walk($variables, 'variable_del');
}
Expand Down
18 changes: 18 additions & 0 deletions modules/islandora_google_scholar/islandora_google_scholar.install
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

/**
* @file
* Install hooks for this module.
*/

/**
* Implements hook_install().
*/
function islandora_google_scholar_uninstall() {
$variables = array(
'islandora_scholar_google_scholar_search_enabled',
'islandora_scholar_google_scholar_primary_search_xpath',
'islandora_scholar_google_scholar_default_search_xpath',
)
array_walk($variables, 'variable_del');
}
16 changes: 16 additions & 0 deletions modules/islandora_scholar_embargo/islandora_scholar_embargo.install
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

/**
* @file
* Install hooks for this module.
*/

/**
* Implements hook_install().
*/
function islandora_scholar_embargo_uninstall() {
$variables = array(
'islandora_embargo_content_models',
)
array_walk($variables, 'variable_del');
}