Adding the ability to truncate results based on the field. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $character_output_count = 0; | ||
| $truncated = FALSE; | ||
| foreach ($value as $index => $current_value) { | ||
| $list_full[] = $current_value; |
There was a problem hiding this comment.
$list_full will be equal to $value directly after this loop, yeah? Why not just assign it?
| elseif ($character_output_count + strlen($current_value) > $truncate_length[$field]['maximum_length'] && !$truncated) { | ||
| $truncation_length = $truncate_length[$field]['maximum_length'] - $character_output_count; | ||
| // Force the display of the full ellipsis. | ||
| if ($truncation_length < strlen(t('...')) && $truncate_length[$field]['add_ellipsis']) { |
There was a problem hiding this comment.
Not overly concerned... this block could be more succinctly written as:
if ($truncate_length[$field]['add_ellipsis']) {
$truncation_length = max($truncation_length, drupal_strlen(t('...')));
}There was a problem hiding this comment.
Also... Should the description of the "maximum_length" bit be updated to say that it may be exceeded by the length of the ellipsis string?
| */ | ||
| function islandora_solr_truncate_field_display($display_values, $max_length, $add_ellipsis, $word_safe, $wordsafe_length, $separator) { | ||
| if (count($display_values) > 0) { | ||
| $mod_path = drupal_get_path('module', 'islandora_solr_metadata'); |
There was a problem hiding this comment.
Missed this last pass: Should move the JS into this module. (since islandora_solr_metadata is already dependent on islandora_solr... Don't want to introduce circular dependencies).
adam-vessey
added a commit
that referenced
this pull request
Jul 23, 2015
Adding the ability to truncate results based on the field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.