Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print nice error message to the screen (without 5.3.3) #363

Merged
merged 4 commits into from
May 10, 2019
Merged

Print nice error message to the screen (without 5.3.3) #363

merged 4 commits into from
May 10, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 23, 2019

This is #362 (the cleaning house remix).

Reminder: PHP 5.3 became End Of Life 4 years, 8 months ago.
https://www.php.net/eol.php

Interested parties

@DiegoPino, @jonathangreen @Islandora/7-x-1-x-committers and anyone with a valid reason to not allow 5.3.3 to fail.

@whikloj whikloj changed the title Display Fedora URI in Drupal Print nice error message to the screen (without 5.3.3) Apr 24, 2019
@jonathangreen
Copy link

My opinion is if we are going to allow failures for PHP 5.3.3, its probably better to just remove it from the build matrix all together. Its failing and we aren't planning to fix it, so spending the travis time building it just to make a broken build doesn't seem worth it to me.

@DiegoPino
Copy link

DiegoPino commented Apr 24, 2019 via email

@bondjimbond
Copy link

I feel like we've talked about 5.3.3 on at least a few calls. Was anyone speaking vehemently in its defense?

@dannylamb
Copy link

@bondjimbond @DiegoPino If committers agree, there's no need for an executive order. And it's been long enough now that maybe 5.3.3 is no longer attractive to those that were clinging on. Or at least maybe they'd be willing to compromise with the allowed fail. So it's still worth a shot IMO.

However, in the event that maybe we need a nudge from higher up the chain, the TAG is meeting soon and this issue has been put on the agenda: https://github.com/Islandora/islandora/wiki/TAG-Meeting---April-26-2019

@DiegoPino
Copy link

DiegoPino commented Apr 24, 2019 via email

@whikloj
Copy link
Member Author

whikloj commented Apr 24, 2019

My proposal with this, is that we always "talk" about removing extremely out-of-date software but we never do it.

This allows us a two-step approach.

  1. Move it to an allowed failure, those for whom 5.3.3 is important can look at fixing it. But the testing is still run.
  2. Review in 6 months with an eye to full removal if it is not fixed.

Copy link

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect. Merging in 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants