New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Islandora 1144 - for the release branch #70
Conversation
…k back to parent only on child pages.
…tes to JAIL display to allow some theming.
I believe there's an issue with this. Perhaps related to this? https://github.com/Islandora/islandora_solution_pack_compound/pull/70/files#diff-b70dff0d0d097b87205025ed79d39ae3R53 |
That line is to not display the list of children unless a) you are viewing the compound (parent) or there are more than 1 child. ie. Don't display a list of the single child if you are already viewing the single child. But I think you are right that I didn't include the TN of the parent and just re-used the Part Of text and linked back to the parent. I'm torn on this, the TN will usually be the same as the first page TN so we will have that displayed twice (for objects with more than 1 child). Not that this is a problem, just wondering if it is extra noise? Let me know what you think. |
I guess the issue is if the parent isn't a compound object per se. In this case, its 2 basic images. The TN would be different. |
Fair point, I have written (what I think) is a fix, but I may not get a chance to test it today. Probably have to wait for 1.6 |
No description provided.