Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Islandora 1144 - for the release branch #70

Closed
wants to merge 14 commits into from
Closed

Islandora 1144 - for the release branch #70

wants to merge 14 commits into from

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Mar 2, 2015

No description provided.

@nhart
Copy link

nhart commented Mar 6, 2015

I believe there's an issue with this.
I have 2 basic image objects linked (A parent with one child). On the child object, I do not see the parent's TN. I only see the "part off" and "manage" bits.

Perhaps related to this? https://github.com/Islandora/islandora_solution_pack_compound/pull/70/files#diff-b70dff0d0d097b87205025ed79d39ae3R53

@whikloj
Copy link
Member Author

whikloj commented Mar 6, 2015

That line is to not display the list of children unless a) you are viewing the compound (parent) or there are more than 1 child. ie. Don't display a list of the single child if you are already viewing the single child.

But I think you are right that I didn't include the TN of the parent and just re-used the Part Of text and linked back to the parent.

I'm torn on this, the TN will usually be the same as the first page TN so we will have that displayed twice (for objects with more than 1 child). Not that this is a problem, just wondering if it is extra noise?

Let me know what you think.

@nhart
Copy link

nhart commented Mar 6, 2015

I guess the issue is if the parent isn't a compound object per se.

In this case, its 2 basic images. The TN would be different.

@whikloj
Copy link
Member Author

whikloj commented Mar 6, 2015

Fair point, I have written (what I think) is a fix, but I may not get a chance to test it today. Probably have to wait for 1.6

@ruebot ruebot closed this Apr 16, 2015
@whikloj whikloj deleted the ISLANDORA-1144 branch October 18, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants