updated issue query so it works better with xacml see jira islandora-118...

[ppound]

...1

[ruebot]

Count this as a bug fix, or feature/improvement?

[ppound]

It addresses jira ticket islandora-1181 which we have listed as a major bug.

I'll have to do another pull request for the release branch.

[ruebot]

Thanks Paul!

[ruebot]

Documenting concerns about dateIssued from our committers call today

If merged as is, it won't account for any existing newspaper objects that don't have dateIssued. dateIssued came in here (h/t @willtp87)

[whikloj]

I think I understand now.

I was confused because dateIssued came in on 2013-03-27 but sequence was made optional 2013-04-01 and sort order was switched to by dateIssued the same day.

Then it was switched back to the current state on 2013-10-16.

I think we added our first bunch of our newspapers in that gap.

[ppound]

We discussed post processing as option for this, I'm thinking post processing will make an already slow loading page slower. We already have a ticket regarding slow issue page loads (https://jira.duraspace.org/browse/ISLANDORA-1167) so maybe we can close this pull request and look at other options like using solr.

Another thing we may want to address when moving to solr is our current practice of iterating over the list of issues and giving the incorrect date to issues that do not currently have a dateIssued (https://github.com/Islandora/islandora_solution_pack_newspaper/blob/7.x/includes/utilities.inc#L116-L135).

[whikloj]

This is waiting on #120

[ruebot]

Goal -- try and get this merged today so we don't need a release branch pull request for this.

@ppound @whikloj I'll focus on testing this this morning.