Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some parts of the UI are not localized #271

Closed
RobertBColton opened this issue Apr 15, 2016 · 1 comment
Closed

Some parts of the UI are not localized #271

RobertBColton opened this issue Apr 15, 2016 · 1 comment

Comments

@RobertBColton
Copy link
Collaborator

RobertBColton commented Apr 15, 2016

The messages in any JComboBox on the preferences is not localized. The best way to solve it is to use a key-value pair with a toString() method. The renderer of the combo should not be changed as this causes issues with various look and feels. A key-value pair is also how it is handled in C#, except that Windows Forms has a DisplayValue property that makes it a little easier. The ResourceInfoFrame is also not localized which is difficult to accomplish.

@RobertBColton RobertBColton changed the title JComboBox's are not localized Some parts of the UI are not localized Apr 15, 2016
@RobertBColton
Copy link
Collaborator Author

I am going to close this as resolved by 6e0915c for several reasons. First, the locale combo itself was fixed/translated properly now. Second, all of the resource frame combos are already translated. Finally, none of the other combos on the preferences frame actually need translated because they are setting the system property values, which do not accept localized values. There's really nothing else to be done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant