Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty Calendar View in 1.4.12 (Appimage) and 1.4.10 (flatpak) #1116

Open
elhennig opened this issue Feb 22, 2024 · 16 comments
Open

Faulty Calendar View in 1.4.12 (Appimage) and 1.4.10 (flatpak) #1116

elhennig opened this issue Feb 22, 2024 · 16 comments
Labels
blocked This issue depends on external projects

Comments

@elhennig
Copy link

elhennig commented Feb 22, 2024

With release 1.4.12 (Appimage Linux) I have the problem, that the calendar view "week" only shows the working days without weekend and entries are shown in the wrong day. So appointments and meetings from yesterday are shown in today's agenda in the week view.
I wonder if this is caused by some change in teams on the MS side or if this is related to the app version? Could this be caused by the change to V2 of Teams?

EDIT: The same is true for the flatpak version 1.4.10

@elhennig elhennig changed the title Faulty Calendar View in 1.4.12 Faulty Calendar View in 1.4.12 (Appimage) and 1.4.10 (flatpak) Feb 22, 2024
@tlo8640
Copy link

tlo8640 commented Mar 6, 2024

I can confirm this.
I'm using the rpmversion teams-for-linux-1.4.13-1.x86_64 on fedora 39
switching calendar view to work week solves this problem for the moment. week view moves calendar entries one day forward.
unfortunately I cannot say, when this problem started.

I checked on web in https://teams.microsoft.com and the problem extists there, too!
using firefox (firefox-123.0-2.fc39.x86_64) on fedora 39 has the same calendar problem,, so izt seems it's not the problem of the unofficial client?

Funny, the teams client running over citrix has the same behavior, perhaps the problem is linux and the LANG settings?

@elhennig
Copy link
Author

elhennig commented Mar 7, 2024

Yes the workaround seems to be, to use the work week view

@tlo8640
Copy link

tlo8640 commented Mar 7, 2024

I think, we cannot blame here this client package ;-)
At least, blaming someone is the last thing I want to do... :-D

A friend of mine is using the (quite old) beta version of the teams client provided by microsoft in the early days of teams. He has the same problem with the calendar.

Playing around, it seems, the problem has its root cause in the wrong(?) handling of LANG and LC_* variables. What part of the desktop or at least teams itself does it wrong...I don't know.

my LANG is set to "en_US.UTF-8" but LC_TIME is set to "de_CH.UTF-8"
Perhaps there is a mismatch between "week start" and "work week start" what makes this problem visible.
My friend has set LC_TIME to "en_DK.UTF-8" and the calendar problem went away.
Setting LANG and LC_TIME to the same values should make this problem disappear, too.

At least, someone with the power to do this could close this issue

@jijojosephk jijojosephk added the blocked This issue depends on external projects label Mar 11, 2024
@jijojosephk
Copy link
Collaborator

Electron or chromium has to support.

@jijojosephk
Copy link
Collaborator

Is this related to #1063 ?

@elhennig
Copy link
Author

No, I do not think so. The normal week view does not work and mixes up entries from different days and displays only 5 days. But this also shows Sundays. Yesterday, Monday, for example it showed the 5 days from Sunday to Thursday, but the entries from Monday were displayed in the Tuesday column.

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Mar 12, 2024

Are you seeing this also in a browser tab? Just to discount ms side issue. Ta

Ignore, I see someone (maybe you) already have checked that and see the same problem.

It is either os config problems or ms teams. I would check with them in the official channels. Hope helps

@elhennig
Copy link
Author

elhennig commented Mar 12, 2024

Actually I cannot check this as the web version has been switched to Teams 2 (?) by my organization already. There I do have a new view besides Day, Work Week and Week: Agenda
All of them seem to works fine.

It could well be that switching to the new Teams in my org causes the display problem with the client.

EDIT: If I change to the developer preview it works better. The week view starts with Sunday, the agenda view is not available, but the calendar entries seem to be shown correctly.

@tlo8640
Copy link

tlo8640 commented Mar 12, 2024

For anybody with this problem, I would recommend to check the LANG and the LC_TIME Variable of the OS.
I have
LANG="en_US.UTF-8"
LC_TIME="de_CH.UTF-8"
This make the Problem visible. in all Teams-variants (Web, this package, teams over Citirx! and the quite old ms provided debian package). I thiknk there is something with the handling of different week starts...
Perhaps the problems is in electron or in teams itself, but not in this repository here:
I didn't found the time to try different settings for LANG and LC_TIME, but I will try to find some minutes and will post the result here.
In my Eyes it's not a bug what can be solved in this package

@elhennig
Copy link
Author

Does that also explain the faulty display in the week view where appointments are sorted into different days? In my case it is not only the week start.

@tlo8640
Copy link

tlo8640 commented Mar 12, 2024

Yes, I think that's the reason for the (by one day) moved appointments in the calendar. Somehow, it wil lbe counted from week start for the right column to be visible or something like this...

@elhennig
Copy link
Author

In the Teams Developer Preview (activated in the menu - info, right top) the display problem seems to be fixed.

Anyway, is there a plan or chance to provide Teams 2 interface in the app? Maybe it is a better idea to have this as discussion....

In my start script for teams I tried to set
export LC_TIME="de_DE.UTF-8"
to the same value as $LANG (before it was empty)

For me this does not solve the issue with the calendar views.

@IsmaelMartinez
Copy link
Owner

Hi @elhennig, my hope is to get some time to look into that react transition, but I had no time to look at it. Apreciate if anyone has time and can have a wee look.

Is only a few files where we "talk" to angular, to get notification count and a few other things.

In here we disable some things (that I am not sure if they even do anything anymore)

injector.get('settingsService').appConfig.promoteMobile = false;
. In general anything around https://github.com/IsmaelMartinez/teams-for-linux/tree/aafed1c90a5a1ca81e45c152891f4add4cd66780/app/browser can be affected, but looks like the documentation on that area is a bit lacking, so a great opportunity for refactoring.

Regarding your issue, it looks more of a locale configuration issue (probably OS specific rather than package specific). This reminds me on an old issue (so maybe check the closed issues). If I was you, I would look for other electron apps that use calendar. Maybe one of the outlook electron apps or similar. See if you have the same issue, as if that is the case then is again a system/OS config. Otherwise trying other packaging systems can help you narrow the issue down.

If it is any consolation, I had a similar problem in macOS using the official app, but changed mac and has gone away.

Tell us how you get on, but I am not sure what else to look at TBH. Hope you find a solution.

@elhennig
Copy link
Author

elhennig commented Mar 26, 2024

I guess this is caused by the switch to classic teams instead of using the new V2. See #1141
For this I do not have a solution, yet.

Also related to #1156

@IsmaelMartinez
Copy link
Owner

Hi @elhennig , is this still an issue? I do remember seen something odd in the macOS app that when away so just to confirm this wasn't a bugger in MS side and is now fixed. Thanks!

@tlo8640
Copy link

tlo8640 commented May 3, 2024

With the "new" Teams I can (for myself) confirm, that there is no faulty calenar view anymore.
But I'm still looking for a way to move the week starting day from sunday to monday
Using Teams (most recent version) on fedora 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue depends on external projects
Projects
None yet
Development

No branches or pull requests

4 participants