Fix cartridge title name encoding (needs to be ShiftJIS string encoding) #49
Conversation
- need to read using ASCI encoding of Shift-JIS (Ascii + Japanese Chars) - add unit tests thanks to SNESLAB Discord and @LuigiBlood for the fix!
…ield - need to read using ASCI encoding of Shift-JIS (Ascii + Japanese Chars) - add unit tests - NOT quite finished yet. thanks to SNESLAB Discord and @LuigiBlood for the fix!
- padding algorithm better - other quality of life improvements - more tests!
binary1230
changed the title
|
All the stuff related to the cart title SHOULD be working now. However, couple things left:
|
| @@ -30,7 +30,7 @@ private void InitializeComponent() | |||
| { | |||
| System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(ExportDisassembly)); | |||
| this.cancel = new System.Windows.Forms.Button(); | |||
| this.button2 = new System.Windows.Forms.Button(); | |||
There was a problem hiding this comment.
this is an unrelated change that crept in here. normally i'd remove it but, it won't hurt anything (just a rename)
- copy some checksum code from Asar - build external test runner for running external tools in unit tests - hook up SuperFamiCheck external tool to print checksum/complement data - write Sprache parsers to parse stdout from SuperFamiCheck - refactor out all ROM import setting code into utility class - write unit tests to compare checksums via several methods now, all seems to be working - various other cleanup
- we'll automatically fix detected bad title string data in older save games - add hooks for units tests - write full unit test suite for this bug - add partial support for mitigations on load/save and test scaffold - fix some bugs with SampleData - more general cleanup
- add unit tests for Bug #50 and associated infrastructure
- further heavy refactor of linked ROM code. this should be pretty much final - add a ton of unit tests - add near-100% test coverage for migration code
- these were added by mistake, shoudn't be present outside the test .csproj
| @@ -2,7 +2,6 @@ | |||
| using System.ComponentModel; | |||
There was a problem hiding this comment.
note for future people: this form contained a lot of controller / business logic, in this PR it's been refactored out so it can more easily be unit tested.
|
this is pretty thoroughly tested (and somewhat overkill on the testing hah) This PR ended up being heavy on refactoring out a few subsystems to make future fixes easy, and allow load/save/import functionality to be unit tested. it should make things much simpler in the future to deal with. I spun off a few low-pri issues that I didn't want to hold up getting a release out for, they are: Thanks @LuigiBlood for the input and Sneslab discord for info on a few things in here. |
WIP, needs a little more testing before it's ready.
fix shift-JIS encoding for reading cart titles