Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Error with status and show reconnecting when country is changed #4

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Fix Error with status and show reconnecting when country is changed #4

merged 3 commits into from
Apr 23, 2020

Conversation

sksavant
Copy link
Contributor

@sksavant sksavant commented Apr 23, 2020 •
edited
Loading

The extension did not work for me with Gnome shell 3.28.4 on Ubuntu 18.04

It seems to be an issue with ByteArray.toString probably

I've also made change to override status as soon as country is clicked.

Isopolito
Isopolito approved these changes Apr 23, 2020
View reviewed changes
Copy link
Owner

@Isopolito Isopolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thank you! I'll have the extension updated through gnome asap

@Isopolito Isopolito merged commit df58b14 into Isopolito:master Apr 23, 2020
@Isopolito Isopolito mentioned this pull request Sep 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isopolito Isopolito Isopolito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sksavant @Isopolito