Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate IDs when getting data from database #1247

Closed
HarelM opened this issue Jun 17, 2020 · 1 comment
Closed

Duplicate IDs when getting data from database #1247

HarelM opened this issue Jun 17, 2020 · 1 comment
Assignees
Labels
bug Critical Needs to be fix ASAP

Comments

@HarelM
Copy link
Member

HarelM commented Jun 17, 2020

Bug

When querying the elastic database sometimes the deserialized objects have the same id in the properties table.
Long discussion can be seen here:
NetTopologySuite/NetTopologySuite.IO.GeoJSON#46

This was emphasized after the implementation of rebuild POIs every hour: #1169

Next steps:

  1. Use Stream instead of deserializing using elastic infra and see if the issue reproduces, if so, dump the text to file.
    https://stackoverflow.com/questions/26753277/how-can-i-pass-through-the-raw-json-response-from-a-nest-elasticsearch-query

  2. If this doesn't help maybe there will be a need to write a custom serializer to handle this...

@HarelM HarelM self-assigned this Jun 17, 2020
@HarelM HarelM added bug Critical Needs to be fix ASAP labels Jun 17, 2020
@HarelM HarelM added this to the Next Release milestone Jun 17, 2020
@HarelM HarelM added this to In Progress in IHM Kanban Jun 17, 2020
HarelM added a commit that referenced this issue Jun 17, 2020
@HarelM
Copy link
Member Author

HarelM commented Jun 18, 2020

Opened an issue for elasticsearch as well:
elastic/elasticsearch-net#4791

HarelM added a commit that referenced this issue Jun 18, 2020
HarelM added a commit that referenced this issue Jun 18, 2020
@HarelM HarelM moved this from In Progress to Waiting for release in IHM Kanban Jun 19, 2020
@HarelM HarelM closed this as completed Jun 19, 2020
@HarelM HarelM removed this from Waiting for release in IHM Kanban Jun 25, 2020
HarelM added a commit that referenced this issue Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical Needs to be fix ASAP
Projects
None yet
Development

No branches or pull requests

1 participant