Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to STJ #1837

Closed
HarelM opened this issue Jan 20, 2023 · 3 comments · Fixed by #1854
Closed

Move to STJ #1837

HarelM opened this issue Jan 20, 2023 · 3 comments · Fixed by #1854
Assignees
@HarelM
Labels
enhancement
Milestone
Version 9.17.48

Comments

@HarelM
Copy link
Member

HarelM commented Jan 20, 2023

What is the problem this feature will solve?

Moving to STJ might improve the site's performance and reduce dependencies

What is the feature you are proposing to solve the problem?

Infta change

What alternatives have you considered or tried?

Keep the current state

Additional information

No response
@HarelM
Copy link
Member Author

HarelM commented Jan 29, 2023 •
edited

Some links to things that should just work, but don't:
dotnet/runtime#1566
NetTopologySuite/NetTopologySuite.IO.GeoJSON#44
NetTopologySuite/NetTopologySuite.IO.GeoJSON#117

Current status: The build is not failing, but there are a lot of runtime issues due to changes in deserialization...

Things to test and fix:

  1. Elastic wrapper in general with IFeature stuff
  2. Imgur was changed and not tested
  3. Return dates from API
  4. Make sure es 8 code is the same for the json serializer
  5. Can't update attributes table ATM
  6. Need to remove temporary NTS feed and use a properly released version
  7. Need to see that the CI passes when using the hourly rebuild
  8. poiId field is used for identification, I was thinking about using the geojson id field like in the spec, but it seems that there's a problem when it comes to MVT, as MVT doesn't support it and so when creating tiles from features that doesn't have an id field in the properties it breaks... :-( Decided to forfeit this ATM.

HarelM added a commit that referenced this issue Jan 31, 2023
@HarelM
Move to STJ #1837 - Second major commit
eef995a
HarelM added a commit that referenced this issue Feb 1, 2023
@HarelM
Move to STJ #1837 - fix date time responses.
585bb6a
HarelM added a commit that referenced this issue Feb 10, 2023
@HarelM
Move to STJ #1837 - small fixes
0b4c07c
HarelM added a commit that referenced this issue Feb 10, 2023
@HarelM
Move to STJ #1837 - Add ability to modify attribute table, using nuge…
cb572f5 
…t from NTS feed
HarelM added a commit that referenced this issue Feb 12, 2023
@HarelM
Move to STJ #1837 - Fix IAttributesTable, fix poiId stuff
eec368c
HarelM added a commit that referenced this issue Feb 13, 2023
@HarelM
Move to STJ #1837 - added missing json properties, date converter, re…
ff5c60a 
…moved unused files.
@HarelM HarelM mentioned this issue Feb 20, 2023
Merged
HarelM added a commit that referenced this issue Mar 29, 2023
@HarelM
Migrate to STJ (#1854)
8c7cdb5 
* Main commit - moved to STJ, there are still open issues...

* Move to STJ #1837 - Second major commit

* Move to STJ #1837 - fix date time responses.

* Move to STJ #1837 - small fixes

* Move to STJ #1837 - Add ability to modify attribute table, using nuget from NTS feed

* Move to STJ #1837 - Fix IAttributesTable, fix poiId stuff

* Move to STJ #1837 - added missing json properties, date converter, removed unused files.

* Code review fixes
@HarelM HarelM self-assigned this Mar 29, 2023
@HarelM HarelM added this to the Next Release milestone Mar 29, 2023
@HarelM HarelM added this to Waiting for release in IHM Kanban Mar 29, 2023
@HarelM
Copy link
Member Author

HarelM commented Mar 30, 2023 •
edited

There is an issue with the OSM id that is used as string in the server side and as number in the client side.
Newtonsoft was able to handle this gracefully but STJ fails.
This is currently in ShareUrl and MapLayerData POCOs.
https://stackoverflow.com/questions/59097784/system-text-json-deserialize-json-with-automatic-casting

@HarelM HarelM reopened this Mar 30, 2023
HarelM added a commit that referenced this issue Apr 2, 2023
@HarelM
Move to STJ #1837 - Fix an issue with number to string conversion
b3e8144
@HarelM
Copy link
Member Author

HarelM commented Apr 16, 2023

This was solved by last commit b3e8144.
I haven't seen any other issues lately.
If new issues arise I will open different issues and solve them as they come.

@HarelM HarelM closed this as completed Apr 16, 2023
HarelM added a commit that referenced this issue May 5, 2023
@HarelM
Move to STJ #1837 - Fix an issue with POI ids
ba4361a
HarelM added a commit that referenced this issue May 6, 2023
@HarelM
Move to STJ #1837 - Fix tests
18cfc1b
@HarelM HarelM removed this from Waiting for release in IHM Kanban May 6, 2023
@HarelM HarelM mentioned this issue May 28, 2023
Closed
2 tasks
This was referenced Aug 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarelM HarelM

Labels
enhancement
Projects
None yet
Milestone
Version 9.17.48
Development

Successfully merging a pull request may close this issue.

Migrate to STJ IsraelHikingMap/Site
1 participant
@HarelM