Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is no longer available #572

Closed
zstadler opened this issue Dec 8, 2017 · 4 comments
Closed

Image is no longer available #572

zstadler opened this issue Dec 8, 2017 · 4 comments

Comments

@zstadler
Copy link
Member

zstadler commented Dec 8, 2017

Bug

An image uploaded to a POI is no longer available.

What I expect to happen

When searching and selecting "מערת הקולומבריום, שמורת טבע חורש עדולם", I expect to see the uploaded image.

What really happened

The image is broken:
image

Thing I think the developers should know, images, links etc.

First reported in changeset 52910710 discussion

@zstadler
Copy link
Member Author

zstadler commented Dec 8, 2017

@HarelM
Copy link
Member

HarelM commented Dec 8, 2017

Checkout the image link in OSM - it has a "_1" at the end.
This means that the original image was named מערת_הקולומבריום_1
When surfing to the following address the page gets redirected (it looses the "_1"):
https://commons.wikimedia.org/wiki/File:Israel_Hiking_Map_מערת_הקולומבריום_1.JPG
Might be the cause of this issue, I'm not sure...
I think that in this case it might be better to just update the OSM link...
My best guess is that this is some wikipedia code, not sure what I can do, any thoughts are welcome...

@zstadler
Copy link
Member Author

zstadler commented Dec 8, 2017

The issue is about the site code, not the OSM data. In other words, what could be done by the site to prevent future links from breaking as all changes to OSM and WikiMedia data were done through the site.

It looks like the "_1" image was removed as duplicate:

10:00, 21 November 2017 JuTa (talk | contribs) deleted page File:Israel Hiking Map מערת הקולומבריום 1.JPG (Exact or scaled-down duplicate: File:Israel Hiking Map מערת הקולומבריום.JPG) (global usage; delinker log)

Perhaps this was caused by an upload that did not result in a successful POI creation, followed by a successful attempt to add the same image to the POI.

To what extent is this scenario handled by #552?

@HarelM
Copy link
Member

HarelM commented Dec 8, 2017

Hopefully this should be prevented by #552 as the upload is now done at once.

@zstadler zstadler closed this as completed Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants