fix(dap-strategy): Removing the need to use the workaround custom debug

- Neotest core fixes ability to supply custom strategy function to
  override situation when this adapter is asked to run the "dap"
  strategy
- Adds deprecation warning regarding previous workaround prior to
  deprecation

lua/neotest-dotnet/init.lua

@@ -118,7 +118,7 @@ DotnetNeotestAdapter.build_spec = function(args)
   logger.debug("neotest-dotnet: Created " .. #specs .. " specs, with contents: ")
   logger.debug(specs)
 
-  if args.is_custom_dotnet_debug then
+  if args.is_custom_dotnet_debug or args.strategy == "dap" then
     if #specs > 1 then
       logger.warn(
         "neotest-dotnet: DAP strategy does not support multiple test projects. Please debug test projects or individual tests. Falling back to using default strategy."
@@ -127,7 +127,19 @@ DotnetNeotestAdapter.build_spec = function(args)
       return specs
     else
       -- Change the strategy to custom netcoredbg strategy and pass in the additional dap args from the user
+      if args.is_custom_dotnet_debug then
+        vim.notify(
+          [[The custom command 
+'run({strategy = require('neotest-dotnet.strategies.netcoredbg'), is_custom_dotnet_debug true})'
+is no longer required. 
+You can now simply use run({strategy = 'dap'}) to debug your tests.
+This custom command will be deprecated in future versions of this adapter.]],
+          vim.log.levels.WARN,
+          { title = "neotest-dotnet" }
+        )
+      end
       specs[1].dap_args = dap_args
+      specs[1].strategy = require("neotest-dotnet.strategies.netcoredbg")
     end
   end
 

lua/neotest-dotnet/strategies/netcoredbg.lua

@@ -38,8 +38,6 @@ return function(spec)
     cwd = spec.cwd,
     env = { ["VSTEST_HOST_DEBUG"] = "1" },
     pty = true,
-    height = spec.strategy.height,
-    width = spec.strategy.width,
     on_stdout = function(_, data)
       nio.run(function()
         data_accum:push(table.concat(data, "\n"))
@@ -114,8 +112,6 @@ return function(spec)
         end)
       end
       attach_win = lib.ui.float.open({
-        height = spec.strategy.height,
-        width = spec.strategy.width,
         buffer = attach_buf,
       })
       vim.api.nvim_buf_set_option(attach_buf, "filetype", "neotest-attach")