java.lang.IllegalArgumentException: x + width must be <= bitmap.width()

[athkalia]

Hello,

I am getting this exception:

java.lang.IllegalArgumentException: x + width must be <= bitmap.width()
 at android.graphics.Bitmap.createBitmap(Bitmap.java:698)
 at com.isseiaoki.simplecropview.CropImageView.getCroppedBitmap(SourceFile:1012)
 at bci.onClick(SourceFile:1064)
 at android.view.View.performClick(View.java:4463)
 at android.view.View$PerformClick.run(View.java:18801)
 at android.os.Handler.handleCallback(Handler.java:808)
 at android.os.Handler.dispatchMessage(Handler.java:103)
 at android.os.Looper.loop(Looper.java:193)
 at android.app.ActivityThread.main(ActivityThread.java:5299)
 at java.lang.reflect.Method.invokeNative(Native Method)
 at java.lang.reflect.Method.invoke(Method.java:515)
 at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:829)
 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:645)
 at dalvik.system.NativeStart.main(Native Method)

every once in a while. Any idea on what's happening there?

Cheers,
Sakis

[igreenwood]

Hi,

Which version are you using?
This bug caused by float precision.
I fixed this bug in ver.1.0.10.
If you are using ver.1.0.10 or newer version,
I have to fix it again...

[athkalia]

Unfortunately I am using 1.0.10 : >

[igreenwood]

OK, I will fix it : )

Can you tell me more specific?

In the previous case, the exception occured when the frame size and the original image size looks equal.
(But the frame size actually was little bigger than original image by the error of float.)

[athkalia]

Sorry, I can't replicate it locally, it happened to some of my users and I just saw the stacktrace in play store. If I manage to replicate it, I'll post again.

[igreenwood]

Hi,

I can't replicate it too, but I added code for checking frame size before cropping the image.
Please try a new version 1.0.15 : )

[andrijans]

I have this issue on 1.0.13 also but its happening random. I will test 1.0.15 now

[andrijans]

I got it on 1.0.15 again

[andrijans]

I found a case. so i load image and i just pull one of right handles to the end of image but without moving frame on screen. As soon as i move frame on screen it works

Update:
In getCroppedBitmap() on line

Bitmap cropped = Bitmap.createBitmap(source, x, y, w, h, null, false);

source width is 2988 and my x is 374 and w is 2615 which is 2989 and that is problem. probably because of some rounding.

In your check for frame size you should check if(x+w>source.getWidth) not if(w>source.getWidth())

[athkalia]

Well played!

[athkalia]

So you'll be releasing a 1.0.16 any time soon ? :D

[igreenwood]

@andrijans Thank you for your PR. I merged your PR and updated.

New version has been released. Please use version 1.0.16.

[igreenwood]

Hi,

Sorry for late response.

Version 1.1.0 has been released.
It contains bug fix for crop algorithm.
Please try sample.

2016-04-03 20:59 GMT+09:00 Zahar notifications@github.com:

I hae this issues again in version 1.0.16 =(

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#40 (comment)