Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Implemented #30

Merged
merged 4 commits into from
Aug 12, 2020
Merged

Web Implemented #30

merged 4 commits into from
Aug 12, 2020

Conversation

JohnGalt1717
Copy link
Contributor

This code enables full web support for screen capture with audio. It outputs webm since that's what chrome supports.

@JohnGalt1717 JohnGalt1717 mentioned this pull request Jul 24, 2020
@salime45
Copy link
Member

salime45 commented Aug 3, 2020

Hi @JohnGalt1717 ,

Sorry for the late, i tried the app right now. Works perfectly. Thanks for your job .

Do you know if the screen record and audio can work in web?

@JohnGalt1717
Copy link
Contributor Author

It should work right now with audio. Are you not seeing that?

@salime45
Copy link
Member

salime45 commented Aug 4, 2020

We tested in Chrome and it doesn't ask for permissions, it just saves a video without audio. Neither audio nor video works in Firefox.

…ck using the most compatible codec to least automatically.
@JohnGalt1717
Copy link
Contributor Author

JohnGalt1717 commented Aug 4, 2020

Ok, should be working. The spec on this functionality is very bad. Appears that audio doesn't work right at all, so I had to approach it a different way for now. Once they get their act together with the wc3 spec and they all work we can update this to work in a single call instead of multiple. The side effect of this work around is that it will request the screen and then request audio after. There's no work around for that right now because no browser properly supports the spec with audio and video at the same time.

This works for Chromium and Firefox. I haven't tested it on Safari as I have no way to do so.

It falls back from h265 to h264 to vp9 to vp8 to opus in that order depending on what is supported by the browser.

Might want to consider requested order of codecs for the future in the platform interface so that we can let users decide the order of importance they want and then we can negotiate based on what the platform supports and the user wants in that order. Could be an optional list on the record methods.

@salime45
Copy link
Member

Hi @JohnGalt1717 ,

Sorry for the late again, i tried the app right now. Works perfectly in chrome and firefox.

@salime45 salime45 changed the base branch from master to web August 12, 2020 09:21
@salime45 salime45 merged commit 4817c21 into Isvisoft:web Aug 12, 2020
@salime45
Copy link
Member

Hi @JohnGalt1717 . Yo know if with this we can take screenshots in png format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants