hq worker info <worker-id> #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spirali
requested changes
Jun 16, 2021
src/client/worker.rs
Outdated
| @@ -45,3 +46,52 @@ pub fn print_worker_info(workers: Vec<WorkerInfo>, gsettings: &GlobalSettings) { | |||
| ]); | |||
| assert!(print_stdout(table).is_ok()); | |||
| } | |||
|
|
|||
| pub fn print_worker_details(worker: WorkerDetail, gsettings: &GlobalSettings) { | |||
There was a problem hiding this comment.
Please do not duplicate print_worker_configuration. If you need to modify it, try to refactor by introducing a new function that is shared by both functions. However as it seems it may be just a one function now
src/client/worker.rs
Outdated
| @@ -1,8 +1,9 @@ | |||
| use cli_table::format::Justify; | |||
| use cli_table::{print_stdout, Cell, Color, Style, Table}; | |||
| use cli_table::{print_stdout, Cell, Color, Style, Table, Row}; | |||
There was a problem hiding this comment.
Please remove all warnings.
src/bin/hq.rs
Outdated
| @@ -123,6 +129,8 @@ enum WorkerCommand { | |||
| List(WorkerListOpts), | |||
| /// Hwdetect | |||
| Hwdetect, | |||
| /// Display details about worker | |||
| Details(WorkerDetailsOpts), | |||
There was a problem hiding this comment.
I would still prefer "hq worker info " as it is more compatible with the rest of the terminology. However, if there is a good reason why call it "detail", lets discuss it.
|
See here: #53 (comment) on how to merge changes from |
Merged
|
@User3574 Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #22